Sujet sur Discussion utilisateur:Tpt

Candalua (discussioncontributions)

Hi Tpt, thank you for your feedback on . This is my first attempt at MW development, and I chose that bug because it looked very straightforward, as an easy solution had already been proposed. But things are never as easy as they look! :D

I would like to understand how to provide default system messages (I see that obviously that change would break things, but somehow I thought that the message was to be added only after the patch was approved). (ok, I found out). Anyway, I will try with the extension.json config, which seems a better idea.

Then if I manage to correctly fix this bug and get to feel confident with the development process, I would like to work on phab:T104566 which would be a great improvement, but first I would like to hear from you about it. I believe a tag like <word-break/> would be best for users, because it would be clearly differentiated from the regular text, whereas a magic word or a special character would not and could lead to misuse and confusion. But what are the cons of introducing a new tag?

Tpt (discussioncontributions)

Hello! Thank you very much for starting to hack on ProofreadPage.

It's a great idea to work on T104566. If possible I would like to avoid inserting a new tag because you need to add support for it in Wikitext parsers, teach the user to use it and it's quite verbose. If we want to go this way it would be nice to get an agreement from the Wikimedia Foundation parser team.

Some tips:

Usually we do not abandon/create new change on gerrit but we amend them. For that you need to amend the git commit (with the --amend option if you use the command line) and keep the Change-Id line.

To clean up trailing whitespace and other formatting you could use phpcs. For that you should first download composer and then execute in the ProofreadPage directory php composer.phar install to install phpcs (or php composer.phar update to update it). When it's done php composer.phar test is going to check if the code formatting is correct and php composer.phar fix is going to fix automatically most of the problems (e.g. trailing tabs, no whitespace inside parenthesis...).

Répondre à « Patch review »